Merge lp://staging/~mardy/signon-ui/oa-capture into lp://staging/signon-ui
Status: | Superseded |
---|---|
Proposed branch: | lp://staging/~mardy/signon-ui/oa-capture |
Merge into: | lp://staging/signon-ui |
Diff against target: |
21 lines (+1/-10) 1 file modified
src/browser-request.cpp (+1/-10) |
To merge this branch: | bzr merge lp://staging/~mardy/signon-ui/oa-capture |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Online Accounts | Pending | ||
Review via email:
|
This proposal has been superseded by a proposal from 2014-04-11.
Commit message
Expect cookies in their raw form
Instead of just expecting a set of "key=value" parts, expect the full cookie blob to be passed. This makes the parsing easier (as QNetworkCookie does already all the job) and make sure that cookies have the correct domain, path and expiration date.
Description of the change
Expect cookies in their raw form
Instead of just expecting a set of "key=value" parts, expect the full cookie blob to be passed. This makes the parsing easier (as QNetworkCookie does already all the job) and make sure that cookies have the correct domain, path and expiration date.
This change does not affect any other component, since at the moment the OA capture story is not enabled.
PASSED: Continuous integration, rev:128 jenkins. qa.ubuntu. com/job/ signon- ui-ci/51/ jenkins. qa.ubuntu. com/job/ signon- ui-trusty- amd64-ci/ 10 jenkins. qa.ubuntu. com/job/ signon- ui-trusty- armhf-ci/ 10 jenkins. qa.ubuntu. com/job/ signon- ui-trusty- armhf-ci/ 10/artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/signon- ui-ci/51/ rebuild
http://