Code review comment for lp://staging/~mardy/account-plugins/microsoft-graph

Revision history for this message
Gary.Wang (gary-wzl77) wrote :

Thanks mardy for this change.
However, I can't manage to login with my account anymore with this change.
I'd say access token is obtained, but error occurs when retrieving the uesr email address by using graph API.

Here is the log:
...
qml: Loading changed
qml: Loading changed
qml: Loading changed
[1104/062626:ERROR:PlatformKeyboardEvent.cpp(84)] Not implemented reached in static bool blink::PlatformKeyboardEvent::currentCapsLockState()
[1104/062628:ERROR:PlatformKeyboardEvent.cpp(84)] Not implemented reached in static bool blink::PlatformKeyboardEvent::currentCapsLockState()
[1104/062631:ERROR:PlatformKeyboardEvent.cpp(84)] Not implemented reached in static bool blink::PlatformKeyboardEvent::currentCapsLockState()
qml: Loading changed
qml: Loading changed
qml: Loading changed
qml: Loading changed
qml: Loading changed
qml: Authenticated; getting cookies
QObject::disconnect: Unexpected null parameter
qml: Request destroyed!
qml: error: 401
qml: response text: {^M
  "error": {^M
    "code": "InvalidAuthenticationToken",^M
    "message": "CompactToken parsing failed with error code: -2147184118",^M
    "innerError": {^M
      "request-id": "fd40b8ca-ca3c-4bfc-84bf-58ba8b6ef0a1",^M
      "date": "2016-11-04T06:27:10"^M
    }^M
  }^M
}

review: Needs Fixing

« Back to merge proposal