Code review comment for lp://staging/~malept/loggerhead/standalone-auth
Revision history for this message
| Mark Lee (malept) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
513534c
demo site
(Get the code!)
> You should add the bug number to NEWS (but someone can do that when landing
> it).
Fixed in revision 405. I wasn't entirely sure whether to add the bug report number, as the dev entries in NEWS are a bit inconsistent in that respect.
> Also, the single-letter variable names are icky, though coming up with 3
> different username variables is a pain.
Yeah, it is :) I attempted to fix this in revision 406.
> Other than that, this looks good to me, but I'm not smart enough to know if it
> really is. It's great that you were able to leverage Paste and Trac to avoid
> writing any unnecessary code. :)
Thanks for the review.