Code review comment for lp://staging/~magentoerpconnect-community/magentoerpconnect/955234

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Hi,

thanks for your patch proposition.

In fact, this is not a problem in product.product.export_inventory.
This method is responsible to export the stock of the input ids.

The cron and the button trigger the method export_inventory on the sale.shop and this one has the responsibility to call product.product.export_inventory with the set of ids exportable products of the shop.

So if a fix has to be done, that's on sale.shop.export_inventory, but this one is abstracted in base_sale_multichannels. So which branch do you use for base_sale_multichannels?

review: Disapprove

« Back to merge proposal