Merge lp://staging/~maddock-evan/onboard/ayatana-appindicator into lp://staging/onboard
Proposed by
Evan Maddock
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~maddock-evan/onboard/ayatana-appindicator |
| Merge into: | lp://staging/onboard |
| Diff against target: |
30 lines (+8/-2) 2 files modified
Onboard/Indicator.py (+4/-1) Onboard/Version.py (+4/-1) |
| To merge this branch: | bzr merge lp://staging/~maddock-evan/onboard/ayatana-appindicator |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Paride Legovini (community) | Abstain | ||
| Onboard Devel Team | Pending | ||
|
Review via email:
|
|||
Commit message
indicator: Enable the use of AyatanaAppIndic
Description of the change
This enables using AyatanaAppIndicator for the AppIndicator backend instead of AppIndicator3. AyatanaAppIndicator is the successor to AppIndicator, and limiting the indicator to the old library means that the Onboard indicator may not be shown on certain Linux distributions and desktop environments.
To ensure backwards compatibility, the indicator will attempt to fall back to the old AppIndicator import if it fails to import AyatanaAppIndic
This was tested on Solus 4.4 using the Budgie Desktop environment (Budgie version 10.8), a combination which uses AyatanaAppIndicator and not AppIndicator.
To post a comment you must log in.
Revision history for this message
| Evan Maddock (maddock-evan) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hello and thanks for this contribution. You requested a review from the Ubuntu Sponsors team, however that teams is meant to review/sponsor source packages ready to be uploaded to the Ubuntu archive. The team is therefore not the right one to review this diff; the upstream developers (Onboard Devel Team) should review it.
I will just add the upstream development looks stalled. This change /may/ be included in a packaging patch, but I suggest submitting it against the onboard Debian package. Currently the Ubuntu package is a sync from Debian.