Code review comment for lp://staging/~mabkenar/ubuntu-keyboard/add-persian-layout

Hi Michael,

Thanks for taking the time to review this plugin and thanks for the nice words :)

The key that is not rendered correctly on your (desktop?) machine is supposed to have "🢐⸽🢒" string on the label and insert U+200C (Zero-Width Non-Joiner) into the text.

A correct rendering on the device is shown here https://goo.gl/vVPwXT and similar key in AOSP is here https://goo.gl/hYBdm6

The rest of the letters on the keyboard are rendered using DejaVu font (it is NOT the Ubuntu font family). DejaVu is the default font for Persian scripts everywhere in the phone (and also in the desktop as of 16.10). Unless fontconfig/etc are at work here, I assume this "🢐⸽🢒" thingy is also rendered with DejaVu. Your screenshot is using FreeSerif for the Persian letters.

For your second point: This is intentional. AFAIK the ZWNJ character is forbidden in email addresses, but it is possible to have ZWNJ in URLs (not in the domain part, but in the page address). Since this character is invisible, I removed it to avoid almost-impossible-to-catch errors when typing email addresses.