Unity 8

Merge lp://staging/~lukas-kde/unity8/windowOpenCloseAnimations into lp://staging/unity8

windowOpenCloseAnimations
Merge into trunk

Proposed by Lukáš Tinkl on 2016-02-17

Status:

Superseded

Proposed branch:

lp://staging/~lukas-kde/unity8/windowOpenCloseAnimations

Merge into:

lp://staging/unity8

Prerequisite:

lp://staging/~unity-team/unity8/launcher-sizing

Diff against target:

550 lines (+171/-35)

15 files modified

CMakeLists.txt (+1/-1)
data/com.canonical.Unity8.gschema.xml (+1/-1)
plugins/Unity/Launcher/launchermodel.cpp (+1/-1)
qml/Launcher/Launcher.qml (+3/-2)
qml/Stages/DesktopStage.qml (+119/-15)
qml/Stages/PhoneStage.qml (+4/-0)
qml/Stages/TabletStage.qml (+4/-0)
qml/Stages/WindowResizeArea.qml (+8/-6)
tests/mocks/Unity/Application/ApplicationManager.cpp (+6/-0)
tests/mocks/Unity/Application/ApplicationManager.h (+1/-1)
tests/plugins/Unity/Launcher/launchermodeltest.cpp (+4/-0)
tests/qmltests/Launcher/tst_Launcher.qml (+13/-3)
tests/qmltests/Stages/ApplicationCheckBox.qml (+2/-2)
tests/qmltests/Stages/tst_DesktopStage.qml (+3/-3)
tests/qmltests/Stages/tst_WindowResizeArea.qml (+1/-0)

To merge this branch:

bzr merge lp://staging/~lukas-kde/unity8/windowOpenCloseAnimations

Medium

In Progress

Link a bug report

Reviewer	Review Type	Date Requested	Status
Lukáš Tinkl (community)			Needs Fixing on 2016-02-22
PS Jenkins bot (community)	continuous-integration	2016-02-17	Needs Fixing on 2016-02-19
Unity8 CI Bot	continuous-integration	2016-02-17	Needs Fixing on 2016-02-19
Nick Dedekind		2016-02-17	Pending
Daniel d'Andrada		2016-02-17	Pending
Michael Terry		2016-02-17	Pending
Review via email: mp+286414@code.staging.launchpad.net

This proposal supersedes a proposal from 2016-02-02.

This proposal has been superseded by a proposal from 2016-03-06.

Commit message

Provide animations for windows opening/closing

Description of the change

Provide animations for windows opening/closing, as described by UX in the original bugreport.

* Are there any related MPs required for this MP to build/function as expected? Please list.

Yes, lp:~unity-team/unity8/launcher-sizing

* Did you perform an exploratory manual test run of your code change and any related functionality?

Yes

* Did you make sure that your branch does not contain spurious tags?

Yes

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

Yes

* If you changed the UI, has there been a design review?

Yes

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-01-11: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7041/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michael Terry (mterry) wrote on 2016-01-12: Posted in a previous version of this proposal

- The app closing animation seems to "stick" on the last frame. Or not smoothly go down to zero opacity. Or something. It didn't look right on my mako.

- closeApplication() takes two arguments, normally only using the first one. It uses the appId if the first argument is not given, which is an odd construction. Maybe just drop the second argument completely, as it's never used?

Otherwise already looks nice. :)

Revision history for this message

Lukáš Tinkl (lukas-kde) wrote on 2016-01-13: Posted in a previous version of this proposal

> - The app closing animation seems to "stick" on the last frame. Or not
> smoothly go down to zero opacity. Or something. It didn't look right on my
> mako.

Agree, using the standard UbuntuNumberAnimation feels much smoother, at least here

> - closeApplication() takes two arguments, normally only using the first one.
> It uses the appId if the first argument is not given, which is an odd
> construction. Maybe just drop the second argument completely, as it's never
> used?

Fixed

> Otherwise already looks nice. :)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-01-13: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7048/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michael Terry (mterry) wrote on 2016-01-13: Posted in a previous version of this proposal

> Agree, using the standard UbuntuNumberAnimation feels much smoother, at least here

I'm still seeing a bit of a pause at the end of the animation on my mako.

Revision history for this message

Lukáš Tinkl (lukas-kde) wrote on 2016-01-13: Posted in a previous version of this proposal

> > Agree, using the standard UbuntuNumberAnimation feels much smoother, at
> least here
>
> I'm still seeing a bit of a pause at the end of the animation on my mako.

I guess it's the reverse easing (UbuntuAnimation.StandardEasingReverse), if I try with StandardEasing, it goes away.

Revision history for this message

Michael Terry (mterry) wrote on 2016-01-13: Posted in a previous version of this proposal

Yeah agreed, StandardEasing looks good to me. Is StandardEasingReverse specifically requested by Design?

Revision history for this message

Lukáš Tinkl (lukas-kde) wrote on 2016-01-13: Posted in a previous version of this proposal

Yes, as per the attached bug report

Revision history for this message

Michael Terry (mterry) wrote on 2016-01-13: Posted in a previous version of this proposal

Hrm. OK, but I ran Vesa's test code. And it didn't seem to pause at the end of the animation for me.

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-01-13: Posted in a previous version of this proposal

PASSED: Continuous integration, rev:2114
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/40/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/40/rebuild

review: Approve (continuous-integration)

Revision history for this message

Michael Zanetti (mzanetti) wrote on 2016-01-15: Posted in a previous version of this proposal

Confirming the close animation stuttering on flo. Could not see it on my laptop.

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-01-15: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2115
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/94/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/94/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Lukáš Tinkl (lukas-kde) wrote on 2016-01-15: Posted in a previous version of this proposal

Please test again, not it feels much smoother on both phone and desktop.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-01-15: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7081/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michael Zanetti (mzanetti) wrote on 2016-01-15: Posted in a previous version of this proposal

the new animation does behave better on my flo, but it's still not 100% perfect. Paying close attention one can still see the last frames sticking around longer than they should. I don't think it's a problem of this branch, rather some sync stuff happening in Unity.Application when cleaning the app out of the memory. The new animation makes it less obvious.

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-01-15: Posted in a previous version of this proposal

PASSED: Continuous integration, rev:2115
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/94/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/94/rebuild

review: Approve (continuous-integration)

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-01-15: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2115
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/94/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/94/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michael Terry (mterry) wrote on 2016-01-15: Posted in a previous version of this proposal

But Michael, wouldn't the Unity.Application work only start happening once opacity is already animated down to zero?

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-01-15: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7084/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-01-15: Posted in a previous version of this proposal

PASSED: Continuous integration, rev:2117
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/101/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/101/rebuild

review: Approve (continuous-integration)

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-01-15: Posted in a previous version of this proposal

PASSED: Continuous integration, rev:2117
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/103/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/103/rebuild

review: Approve (continuous-integration)

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-01-15: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2117
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/103/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/103/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Lukáš Tinkl (lukas-kde) wrote on 2016-01-18: Posted in a previous version of this proposal

Animation is now smooth on devices, using a small hack to pause the animation at the end before actually closing the application.

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-01-18: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2118
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/108/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/108/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-01-18: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2118
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/108/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/108/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michael Terry (mterry) wrote on 2016-01-18: Posted in a previous version of this proposal

Looks good to me. The delay after the animation is a gross hack, but not the worst thing. I sat with Lukas and couldn't figure out why it would be needed. But it seems to be for now.

So approved from my end. Animation is smooth with the delay.

Tested it manually.
CI bot is crazy right now, let's wait for it to fix itself before top-approving.
No tags.

review: Approve

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-01-18: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2118
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/108/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/108/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-01-18: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7089/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Nick Dedekind (nick-dedekind) wrote on 2016-01-18: Posted in a previous version of this proposal

I believe this is what is causing the window to not be visible when opening a maximised app.

review: Needs Fixing

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-01-18: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2118
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/126/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/126/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Lukáš Tinkl (lukas-kde) wrote on 2016-01-19: Posted in a previous version of this proposal

Starting maximized apps should be fixed now

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-01-19: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2120
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/132/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/132/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-01-19: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7098/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-01-19: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2121
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/133/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/133/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-01-19: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7099/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michael Terry (mterry) wrote on 2016-01-19: Posted in a previous version of this proposal

LGTM now, maximized works.

review: Approve

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-02-02: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2122
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/254/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/254/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-02: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7197/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2016-02-10: Posted in a previous version of this proposal

make tryShell
- select desktop size
- unlock screen
- select windowed mode

window gets broken

review: Needs Fixing

Revision history for this message

Lukáš Tinkl (lukas-kde) wrote on 2016-02-10: Posted in a previous version of this proposal

OK, fixed the behavior, just not sure where to take the default size from, I have this atm:

PropertyChanges {
  target: decoratedWindow
  requestedWidth: resizeArea.defaultWidth
  requestedHeight: resizeArea.defaultHeight
}

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2016-02-10: Posted in a previous version of this proposal

Could you please re-merge your prerequisite? You seem to have an outdated version of it....

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-02-10: Posted in a previous version of this proposal

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/308/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Lukáš Tinkl (lukas-kde) wrote on 2016-02-10: Posted in a previous version of this proposal

> Could you please re-merge your prerequisite? You seem to have an outdated
> version of it....

Rebased

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-02-10: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2124
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/310/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/431/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/454
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/472
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/472
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/468/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/468/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/468/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/468/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/468/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/468/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/310/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-10: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7248/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-02-10: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2125
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/313/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/434/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/457
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/475
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/475
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/471/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/471/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/471/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/471/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/471/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/471/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/313/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-10: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7253/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-02-10: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2126
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/317/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/438/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/461
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/479
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/479
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/475/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/475/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/475/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/475/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/475/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/475/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/317/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Lukáš Tinkl (lukas-kde) wrote on 2016-02-10: Posted in a previous version of this proposal

Done, no more regressions spotted

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-02-10: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2127
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/318/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/439/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/462
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/480
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/480
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/476/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/476/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/476/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/476/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/476/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/476/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/318/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-02-10: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2128
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/320/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/441/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/464
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/482
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/482
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/478/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/478/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/478/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/478/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/478/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/478/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/320/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-10: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7257/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-02-10: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2129
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/321/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/442/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/465
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/483
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/483
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/479/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/479/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/479/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/479/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/479/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/479/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/321/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-10: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7259/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-11: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7261/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2016-02-11: Posted in a previous version of this proposal

* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

* Did CI run pass? If not, please explain why.
Will never pass due to unity-api dependency from the prerequisites

* Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-02-11: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2130
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/324/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/445/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/468
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/486
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/486
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/482/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/482/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/482/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/482/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/482/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/482/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/324/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-02-17:

FAILED: Continuous integration, rev:2132
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/418/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/566/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/589
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/607
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/607
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/603/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/603/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/603/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/603/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/603/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/603/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/418/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-17:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7353/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~lukas-kde/unity8/windowOpenCloseAnimations updated on 2016-02-19

2133. By Lukáš Tinkl on 2016-02-19: merge prereq

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-02-19:

FAILED: Continuous integration, rev:2133
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/442/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/596/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/619
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/637
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/637
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/633/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/633/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/633/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/633/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/633/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/633/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/442/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-19:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7373/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michael Terry (mterry) wrote on 2016-02-22:

Maximized apps don't seem to animate on open or close.

Revision history for this message

Lukáš Tinkl (lukas-kde) wrote on 2016-02-22:

On (maxed) window closing, I definitely do get the scale/opacity change although I agree when opening maximized windows, the animation is not there:

From WindowResizeArea.qml (r. 1978.4.2 <email address hidden> 20150925)

if (windowState === WindowStateStorage.WindowStateMaximized) {
target.maximize(false)
}

Not sure what the intention is here

Revision history for this message

Michael Zanetti (mzanetti) wrote on 2016-02-22:

> On (maxed) window closing, I definitely do get the scale/opacity change
> although I agree when opening maximized windows, the animation is not there:
>
> From WindowResizeArea.qml (r. 1978.4.2 <email address hidden>
> 20150925)
>
> if (windowState === WindowStateStorage.WindowStateMaximized) {
> target.maximize(false)
> }
>
> Not sure what the intention is here

The issue I was solving with this is that otherwise a maximized window would start normal and then aminate to fullscreen. We might need to rework that a little to make the open animation play but not the maximize animation.

Revision history for this message

Lukáš Tinkl (lukas-kde) wrote on 2016-02-22:

I guess this should go to another MP (offtopic for this one), will likely need more UX hints.

Revision history for this message

Lukáš Tinkl (lukas-kde) wrote on 2016-02-22:

Marking this as WIP, needs to handle starting/closing apps from outside of the stage too (e.g. from launcher)

review: Needs Fixing

lp://staging/~lukas-kde/unity8/windowOpenCloseAnimations updated on 2016-04-14

2134. By Lukáš Tinkl on 2016-02-24

merge trunk

2135. By Lukáš Tinkl on 2016-02-24

handle the close case coming from launcher

2136. By Lukáš Tinkl on 2016-02-24

fix the launcher ApplicationManager mock

2137. By Lukáš Tinkl on 2016-02-26

restart app if focusing doesn't work

happens with dash sometimes

2138. By Lukáš Tinkl on 2016-02-26

make the close animation testable using the App checkbox

2139. By Lukáš Tinkl on 2016-02-27

fix fullscreen apps being offset by the left margin

2140. By Lukáš Tinkl on 2016-02-27

disallow resizing windows up past the Panel

2141. By Lukáš Tinkl on 2016-02-28

fix closing animation for minimized apps

2142. By Lukáš Tinkl on 2016-02-29

fullscreen apps fix

2143. By Lukáš Tinkl on 2016-02-29

fix for fullscreen windows height

2144. By Lukáš Tinkl on 2016-03-06

merge lp:~mzanetti/unity8/launcher-sizing

2145. By Lukáš Tinkl on 2016-03-06

revert keymap (unrelated) changes

2146. By Lukáš Tinkl on 2016-03-06

depend on -15 appl framework

2147. By Lukáš Tinkl on 2016-03-06

implement maximizeHorizontally/Vertically

2148. By Lukáš Tinkl on 2016-03-07

requestStop() here

2149. By Lukáš Tinkl on 2016-03-07

save/restore the correct state in all cases

implement (easy now) maximize horizontal/vertical using it

2150. By Lukáš Tinkl on 2016-03-12

merge trunk

2151. By Lukáš Tinkl on 2016-03-21

merge trunk

2152. By Lukáš Tinkl on 2016-03-22

merge trunk

2153. By Lukáš Tinkl on 2016-03-24

merge trunk, resolve conflicts

2154. By Lukáš Tinkl on 2016-04-07

merge trunk

2155. By Lukáš Tinkl on 2016-04-14

merge trunk

Unmerged revisions

2155. By Lukáš Tinkl on 2016-04-14

merge trunk

2154. By Lukáš Tinkl on 2016-04-07

merge trunk

2153. By Lukáš Tinkl on 2016-03-24

merge trunk, resolve conflicts

2152. By Lukáš Tinkl on 2016-03-22

merge trunk

2151. By Lukáš Tinkl on 2016-03-21

merge trunk

2150. By Lukáš Tinkl on 2016-03-12

merge trunk

2149. By Lukáš Tinkl on 2016-03-07

save/restore the correct state in all cases

implement (easy now) maximize horizontal/vertical using it

2148. By Lukáš Tinkl on 2016-03-07

requestStop() here

2147. By Lukáš Tinkl on 2016-03-06

implement maximizeHorizontally/Vertically

2146. By Lukáš Tinkl on 2016-03-06

depend on -15 appl framework

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Lukáš Tinkl

Mohammad Rakibul Hasan

Unity Team