Code review comment for lp://staging/~lukas-kde/unity8/windowOpenCloseAnimations

Revision history for this message
Michael Terry (mterry) wrote :

Looks good to me. The delay after the animation is a gross hack, but not the worst thing. I sat with Lukas and couldn't figure out why it would be needed. But it seems to be for now.

So approved from my end. Animation is smooth with the delay.

Tested it manually.
CI bot is crazy right now, let's wait for it to fix itself before top-approving.
No tags.

review: Approve

« Back to merge proposal