Merge lp://staging/~lukas-kde/qtmir/betterSessionManagement into lp://staging/qtmir

Proposed by Lukáš Tinkl
Status: Work in progress
Proposed branch: lp://staging/~lukas-kde/qtmir/betterSessionManagement
Merge into: lp://staging/qtmir
Diff against target: 393 lines (+16/-113)
8 files modified
src/modules/Unity/Application/application.cpp (+3/-33)
src/modules/Unity/Application/application.h (+1/-2)
src/modules/Unity/Application/application_manager.cpp (+6/-3)
src/modules/Unity/Application/mirsurface.cpp (+0/-45)
src/modules/Unity/Application/mirsurface.h (+0/-11)
tests/framework/qtmir_test.cpp (+0/-3)
tests/modules/ApplicationManager/application_manager_test.cpp (+6/-6)
tests/modules/WindowManager/mirsurface_test.cpp (+0/-10)
To merge this branch: bzr merge lp://staging/~lukas-kde/qtmir/betterSessionManagement
Reviewer Review Type Date Requested Status
Mir development team Pending
Review via email: mp+316211@code.staging.launchpad.net

Commit message

Do not forcefully kill and hide apps, let them handle the SIGTERM
and give them a chance to reject it if needed

Description of the change

WIP: do not forcefully kill and hide apps, let them handle the SIGTERM
and give them a chance to reject it if needed

Mostly dropping the closeTimer and InternalState::Closing; some tests are still failing due to the altered internal state machine :/

Needs https://code.launchpad.net/~lukas-kde/unity8/betterSessionManagement/+merge/316212 in order to prevent an endless loop at session end (logout/reboot)

To post a comment you must log in.
592. By Lukáš Tinkl

revert unnecessary changes, still works fine and fixes 3 failing tests

593. By Lukáš Tinkl

merge trunk

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Now that MirSurface::close() is a pretty innocuous call, I think it should no longer have any effect on the Application and Session state machines.

Maybe there's no longer a Closing state anymore.

594. By Lukáš Tinkl

merge trunk, resolve conflicts

595. By Lukáš Tinkl

WIP remove Closing state

596. By Lukáš Tinkl

merge trunk, resolve conflicts

597. By Lukáš Tinkl

merge trunk, resolve conflicts

Unmerged revisions

597. By Lukáš Tinkl

merge trunk, resolve conflicts

596. By Lukáš Tinkl

merge trunk, resolve conflicts

595. By Lukáš Tinkl

WIP remove Closing state

594. By Lukáš Tinkl

merge trunk, resolve conflicts

593. By Lukáš Tinkl

merge trunk

592. By Lukáš Tinkl

revert unnecessary changes, still works fine and fixes 3 failing tests

591. By Lukáš Tinkl

do not forcefully kill and hide apps, let them handle the SIGTERM
and give them a chance to reject it if needed

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches