Merge lp://staging/~ltrager/flash-kernel/get_machine_deps into lp://staging/flash-kernel

So someone would use this by then doing something like:

if flash-kernel --supported; then
   pkgs=$(flash-kernel --get-machine-required-packages) || fail "failed getting required packages"
   apt-get install -qy $pkgs
fi

right ? I'm not sure that the 'check_supported' usage in your addition helps at all, because the user of this somehow has to determine the difference between failure due to "not supported" or other failure. So they end up having to do the above, right?

One thing i might suggest is just changing it to be more generic and allow getting of any field.

if [ "$1" = "--get-machine-field" ]; then
   get_machine_field "$machine" "$2"
   exit
fi

Lee, Thanks for doing this!

Thanks for the review. I've made the argument more generic as you suggested. I also confirmed check_supported isn't needed, get_machine_field will exit 1 if its not found.

"I also confirmed check_supported isn't needed, get_machine_field will exit 1 if its not found."

Well, thats unfortunate.

What we want to have a program do is say : give me a list of packages that I shoudl install

and allow for that list to be "".

As I understand it right now, if the hardware should not install any, it will exit 1.

But then the caller cannot determine the differnce between failure for unexpected return
and "no packages to install".

Perhaps we then almost need a specific path for this.

Does that make sense ?

I've updated the MP so --get-machine-field always exit's 0. If the machine isn't supported or doesn't have the matching field nothing will be printed.