Code review comment for lp://staging/~ltrager/curtin/lp1640519

Thanks for tackling this Lee!

I do fear that the strategy of copying flash-kernel code won't be very maintainable, as the platforms supported by a given flash-kernel version and the curtin in-use will quickly fall out of sync. Note that flash-kernel is a package that is frequently updated, even in stable releases.

My recommendation would be to keep flash-kernel installed on all arm64 systems. This should be safe - flash-kernel now knows to ignore uefi-based systems, and those are the only supported systems that do not require flash-kernel.

Alternatively, I'd suggest querying flash-kernel at runtime by sourcing it's /usr/share/flash-kernel/functions and using get_machine()/check_supported() to determine if it is supported by flash-kernel. This would avoid the overhead of having flash-kernel installed on UEFI systems. Though, that overhead is so low that I personally wouldn't bother.