Code review comment for lp://staging/~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-resolution-independance

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

For GPL/LGPL, I don't know if there's a strict policy as long as libraries are LGPL and v3 of either license is in use. Considering the core parts of UITK are used in non-defined amount of applications (including possibly proprietary ones), it's probably easiest to just state that UITK is LGPLv3.

MIT license is fine: http://opensource.org/licenses/MIT - there are no restrictions except for the requirement to include copyright/license notice. If LGPLv3 would require the whole to be offered as LGPLv3, then the originally MIT licensed content can be redistributed under LGPLv3 whole.

Please update debian/copyright following the machine readable format it is in. That is, add at the bottom:

File: path/to/yourmitfile.c
Copyright: 201x, copyright owner
License: MIT

License: MIT
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in
 all copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.

review: Needs Fixing

« Back to merge proposal