Linaro Android Build Tools

Code review comment for lp://staging/~liuyq0307/linaro-android-build-tools/support-http

  1. support-http
  2. Merge into trunk
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

This looks pretty good, thanks for making sure that proper URL schema is used throughout.

The only problem is at line 48. I proposed that value of LAVA_TOKEN_FILE would be just a filename of file containing a token, relative to the predefined dir (/var/run/lava/), not absolute path name. I don't think it's worth to expose full path name to lava tokens in the public build configs.

review: Needs Fixing

« Back to merge proposal