Code review comment for lp://staging/~liuyq0307/linaro-android-build-tools/add-monkey-l-a-t

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

thanks for review.

Thanks for bringing that up, that's how we'd like to handle such
> changes for sure - test them on a sandbox before deploying on
> production. I've created one at
> https://ec2-75-101-195-88.compute-1.amazonaws.com/
>
Thanks, but until now there hasn't been one build:(
How can i make a build there?

> Reviewing changes once again:
>
> 97 - "server": "http://validation.linaro.org/lava-server/dashboard",
> 98 + "server": "http://validation.linaro.org/lava-server/RPC2/",
>
> Are you sure this is right? Why exactly such change is needed?
>

yes, this is right. the dashoard one is deprecated.
and in the future we will use the new url, see the hlep of api about
lava-server.
http://validation.linaro.org/lava-server/api/help/

Thanks,
Yongqin Liu

« Back to merge proposal