Code review comment for lp://staging/~liuyq0307/linaro-android-build-tools/add-monkey-l-a-t

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

> + image_type = os.environ.get("IMAGE_TYPE")
>
> What's being done here? If it calls for adding another build config variable,
> it's likely superfluous (unless there're reasons why it's not).
sorry, I didn't recognize that this file only be used for android-build.
I will delete the relevant source.

> Also, braces placement needs fixing, it for sure worse than was before. Rule
> of thumb is to just follow style of the existing code (and minimize any
> whitespace changes).
I have modify the braces placement according the policy that minimize any whitespace changes.
BTW, is there any coding style for braces?

> And can you please look thru associated blueprint's whiteboard, it seems to
> have typos which make it a bit unclear ("Acceptance: Monkey for as long as it
> can", "Update the meeting to a weekly")
I have updated the bp, is it ok now.

And is there any environment that I can test this file?
I want to see after the execution of this file, is the result displayed ok.

« Back to merge proposal