Code review comment for lp://staging/~liuyq0307/linaro-android-build-tools/add-monkey-l-a-t

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

thanks for review
> Is the new linaro_android_test_run action available on validation.linaro.org
> and able to run both monkey and 0xbench?
yes, linaro_android_test_run is available on validation.linaro.org, and can run both monkey and 0xbench

> If not then we will have to hold off on deploying this until it is.
>
> 54 + # Board-specific parameters
>
> Extra space included in the indentation on that line.
sorry, delete the extra space

> 122 + submin_results_command = "submit_results"
> 123 + if image_type == 'android':
> 124 + submin_results_command = "submit_results_on_host"
>
> Typo in variable name, it should be "submit_results_command"
sorry, I will fixing it.

« Back to merge proposal