Code review comment for lp://staging/~liuyq0307/linaro-android-build-tools/add-monkey-l-a-t

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

+ image_type = os.environ.get("IMAGE_TYPE")

What's being done here? If it calls for adding another build config variable, it's likely superfluous (unless there're reasons why it's not).

Also, braces placement needs fixing, it for sure worse than was before. Rule of thumb is to just follow style of the existing code (and minimize any whitespace changes).

And can you please look thru associated blueprint's whiteboard, it seems to have typos which make it a bit unclear ("Acceptance: Monkey for as long as it can", "Update the meeting to a weekly")

review: Needs Fixing

« Back to merge proposal