Code review comment for lp://staging/~linaro-landing-team-freescale/linaro-image-tools/mx53loco-fixvga

On Mon, 21 Mar 2011 03:54:54 -0000, Eric Miao <email address hidden> wrote:
> Eric Miao has proposed merging lp:~linaro-landing-team-freescale/linaro-image-tools/mx53loco-fixvga into lp:linaro-image-tools.
>
> Requested reviews:
> Linaro Maintainers (linaro-maintainers)
>
> For more details, see:
> https://code.launchpad.net/~linaro-landing-team-freescale/linaro-image-tools/mx53loco-fixvga/+merge/54147
>
> This fixed the issue of VGA not enabled by default by providing the correct kernel command line.
> --
> https://code.launchpad.net/~linaro-landing-team-freescale/linaro-image-tools/mx53loco-fixvga/+merge/54147
> Your team Linaro Infrastructure is subscribed to branch lp:linaro-image-tools.
> === modified file 'linaro_media_create/boards.py'
> --- linaro_media_create/boards.py 2011-03-17 17:48:49 +0000
> +++ linaro_media_create/boards.py 2011-03-21 03:54:44 +0000
> @@ -474,6 +474,7 @@
> initrd_addr = '0x71800000'
> load_addr = '0x70008000'
> kernel_suffix = 'linaro-lt-mx53'
> + extra_boot_args_options = ('di1_primary tve ')
>
>
> class EfikamxConfig(Mx51Config):
>

From IRC:

<james_w> ericm, about https://code.launchpad.net/~linaro-landing-team-freescale/linaro-image-tools/mx53loco-fixvga/+merge/54147 , what does the option actually do?
<ericm> james_w, it's for enabling display output on mx53 loco board
<james_w> right, is there some way that it could be the default?
<ericm> james_w, it's possible though
<james_w> it's better if the kernel just gets it right, so I'd prefer not to merge that if we can avoid it
<ericm> james_w, ok - got you
<james_w> ericm, great, are you going to pursue that approach?
* ronynandy has quit (Remote host closed the connection)
<ericm> james_w, I'll take a look - not really sure if it's feasible with Freescale's existing kernel
<james_w> ok, let me know what you find
<ericm> james_w, sure
<ericm_> james_w, I believe I have to discuss this option with Freescale tomorrow, will get back to you then
<james_w> ericm_, ok, thanks

Thanks,

James