python-oops-tools

Code review comment for lp://staging/~lifeless/python-oops-tools/amqp-polish

  1. amqp-polish
  2. Merge into trunk
Revision history for this message
William Grant (wgrant) wrote :

10:45:38 < wgrant> lifeless: + oopsids.add(with_oops.lower())
10:45:44 < wgrant> lifeless: Isn't that going to lower the OOPS- too?
10:45:47 < wgrant> Which is probably wrong.
10:46:25 < lifeless> well, depends on where you consider the abstraction barrier
10:46:37 < lifeless> but yes, I can see that being an issue.
10:47:16 < lifeless> will make it a .update(map(lambda x:'OOPS-' + x, oopsids)) instead
10:47:19 < wgrant> Thanks.

review: Approve (code)

« Back to merge proposal