pyjuju

Code review comment for lp://staging/~lifeless/pyjuju/bug-945505

  1. bug-945505
  2. Merge into trunk
Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

I'm -1 on changing this as suggested. If a DNS name is available, it should be provided instead of the IP address, and we shouldn't be changing such an API without better reasoning. What's breaking at the moment? Do we have cases where the DNS name does not exist? If so, we could fallback to the IP adddress.

review: Disapprove
Reply

« Back to merge proposal