Code review comment for lp://staging/~larsu/libindicator/ng-add-scrolling

Revision history for this message
Charles Kerr (charlesk) wrote :

I like the idea behind this addition to the root menu action dict.

The patch is fine too. If I'm reading the diff right, it even fixes a potential (unlikely) leak we missed before, leaking G_MENU_ATTRIBUTE_ACTION strings that don't begin with "indicator."

looks like a g_message() snuck in by accident. Marking as "needs fixing" for that small issue only -- the rest is great.

review: Needs Fixing

« Back to merge proposal