Code review comment for lp://staging/~larsu/indicator-messages/add-simple-dbus-api

Revision history for this message
Ted Gould (ted) wrote :

On Wed, 2014-09-17 at 23:02 +0000, Lars Uebernickel wrote:

> > I don't think that we want an interface that is based on passing dictionaries
> > around. I'd rather have something that is more explicit about the structure of
> > the notification, what is required and what the behavior is.
>
> Dictionary keys are well-defined and expected to be implemented by the server. What do you suggest? A D-Bus method call with everything as arguments?

Yes, I think being explicit is better in cases like this. But I'm also
not convinced there's room to have one end point for all notifications.
There's lots of ways to notify, transient, etc. It perhaps would make
more sense to have an endpoint for each.

« Back to merge proposal