Code review comment for lp://staging/~laney/ubuntu-system-settings/reset-api

Revision history for this message
Alberto Mardegan (mardy) wrote :

L149: better delete the component here (though it's not leaked because it has the Plugin as its parent, so it's not a big issue)

L284,L285: indent the QML code one space more

L291: is this really needed? If it is, then maybe we should have this code in src/plugin.cpp, and not just in the test plugin.

All the rest looks fine to me, though I'd really like to see the addition of the code I suggested in the previous comment. :-)

review: Needs Fixing

« Back to merge proposal