Merge lp://staging/~l3on/ubuntu-packaging-guide/new-sidebar into lp://staging/ubuntu-packaging-guide
Proposed by
Leo Iannacone
Status: | Merged |
---|---|
Merged at revision: | 104 |
Proposed branch: | lp://staging/~l3on/ubuntu-packaging-guide/new-sidebar |
Merge into: | lp://staging/ubuntu-packaging-guide |
Diff against target: |
312 lines (+165/-38) 7 files modified
BORROWED-CODE (+3/-0) Makefile (+3/-1) debian/control (+2/-2) themes/ubuntu/layout.html (+4/-35) themes/ubuntu/sidebar.html (+55/-0) themes/ubuntu/static/home.css (+77/-0) themes/ubuntu/static/main.js (+21/-0) |
To merge this branch: | bzr merge lp://staging/~l3on/ubuntu-packaging-guide/new-sidebar |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel Holbach | Approve | ||
Review via email: mp+105360@code.staging.launchpad.net |
Description of the change
This patch tries to provide a new Sidebar for ubuntu-
A build-test can be found here:
http://
What I used:
* Images/icons come from Humanity icon theme.
* Jquery (added to the "_static" dir, of course we should use instead
jquery lib shipped with with Ubuntu, but I do not know how I can do
it)
Have a great day.
Leo.
To post a comment you must log in.
Thanks a lot for your work on this Leon!
I have a few questions:
- Why do you reset LANGS? I'm not sure I understand what's going on. :-)
- Do we specifically need jquery 1.6.1? Or is anything >= 1.6.1 fine? If so,
we could rely on the system jquery, which has been >= 1.6.1 since oneiric.
- Could you document in BORROWED-CODE where you got the icons from?
Thanks again for your great work! This is great!