Merge lp://staging/~kyrofa/unity-scope-snappy/progress_daemon_main into lp://staging/~unity-api-team/unity-scope-snappy/trunk

Proposed by Kyle Fazzari
Status: Merged
Approved by: Kyle Fazzari
Approved revision: 39
Merged at revision: 17
Proposed branch: lp://staging/~kyrofa/unity-scope-snappy/progress_daemon_main
Merge into: lp://staging/~unity-api-team/unity-scope-snappy/trunk
Prerequisite: lp://staging/~kyrofa/unity-scope-snappy/progress_daemon_webdm_package_manager_interface
Diff against target: 304 lines (+290/-0)
3 files modified
progress-daemon/daemon/daemon.go (+115/-0)
progress-daemon/daemon/daemon_test.go (+145/-0)
progress-daemon/main.go (+30/-0)
To merge this branch: bzr merge lp://staging/~kyrofa/unity-scope-snappy/progress_daemon_main
Reviewer Review Type Date Requested Status
Xavi Garcia (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Unity API Team Pending
Review via email: mp+262008@code.staging.launchpad.net

Commit message

Finish the progress daemon.

Description of the change

Finish the progress daemon.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
34. By Kyle Fazzari

Request name AFTER interfaces are exported.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
35. By Kyle Fazzari

Merge prerequisite changes from lp:~kyrofa/unity-scope-snappy/progress_daemon_webdm_package_manager_interface

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
36. By Kyle Fazzari

Merge prerequisite changes from lp:~kyrofa/unity-scope-snappy/progress_daemon_webdm_package_manager_interface

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
37. By Kyle Fazzari

Merge prerequisite changes from lp:~kyrofa/unity-scope-snappy/progress_daemon_webdm_package_manager_interface

Also change interface name to "com.canonical.applications.Download" so
the progress widget will work.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
38. By Kyle Fazzari

Remove stupid sleep test.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
39. By Kyle Fazzari

Merged prerequisite changes from lp:~kyrofa/unity-scope-snappy/progress_daemon_webdm_package_manager_interface

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Xavi Garcia (xavi-garcia-mena) wrote :

Looks good to me.
I've also tested the service with d-feet and seems to work fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches