Ubuntu
dkms package

Merge lp://staging/~kroq-gar78/ubuntu/precise/dkms/fix-989998 into lp://staging/ubuntu/precise/dkms

  1. Precise (12.04)
  2. fix-989998
  3. Merge into precise
Proposed by Aditya V
Status: Work in progress
Proposed branch: lp://staging/~kroq-gar78/ubuntu/precise/dkms/fix-989998
Merge into: lp://staging/ubuntu/precise/dkms
Diff against target: 33 lines (+10/-1)
2 files modified
debian/changelog (+6/-0)
debian/control (+4/-1)
To merge this branch: bzr merge lp://staging/~kroq-gar78/ubuntu/precise/dkms/fix-989998
Reviewer Review Type Date Requested Status
Oliver Grawert Needs Fixing
Ubuntu branches Pending
Felix Geyer Pending
Review via email: mp+107582@code.staging.launchpad.net

This proposal supersedes a proposal from 2012-04-28.

Description of the change

I added 'dpkg-dev' and 'debhelper' to Suggests in debian/control.

To post a comment you must log in.
Revision history for this message
Felix Geyer (debfx) wrote : Posted in a previous version of this proposal

Most of the time dkms is only used for building kernel modules so adding them as dependecies is the wrong solution.
dkms is on various CDs so adding them to Depends or Recommends would also waste some space on the images.

Adding dpkg-dev and debhelper to Suggests and ensuring that dkms has a sensible error message if they are missing seems like the best solution to me.

review: Disapprove
Revision history for this message
Aditya V (kroq-gar78) wrote :

Should I do this on the Quantal branch instead since Precise is already released?

Reply
Revision history for this message
Oliver Grawert (ogra) wrote :

if you move dependencies to "Suggests:" you need to remove them from the "Depends:" field.

stable release updates to precise are allowed, just make sure the bug has the necessary bits
(see https://wiki.ubuntu.com/StableReleaseUpdates) in the description fields.

in parallel you should prepare the fix for quantal as well...

review: Needs Fixing
Reply
Revision history for this message
Stéphane Graber (stgraber) wrote :

Based on the above comment, marking "work in progress".
Please note that in order to SRU this change, it'll also need to be fixed in the development version of Ubuntu (quantal). Details on the SRU process can be found at: https://wiki.ubuntu.com/StableReleaseUpdates

Please change this branch status back to Needs review when you're done with the changes.

Reply

Unmerged revisions

53. By Aditya V

debian/control: moved 'dpkg-dev' and 'debhelper' from Depends to Suggests

52. By Aditya V

debian/control: added 'dpkg-dev' and 'debhelper' to Depends (LP: #989998)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: