Code review comment for lp://staging/~kroq-gar78/ubuntu/precise/dkms/fix-989998

Revision history for this message
Felix Geyer (debfx) wrote :

Most of the time dkms is only used for building kernel modules so adding them as dependecies is the wrong solution.
dkms is on various CDs so adding them to Depends or Recommends would also waste some space on the images.

Adding dpkg-dev and debhelper to Suggests and ensuring that dkms has a sensible error message if they are missing seems like the best solution to me.

review: Disapprove

« Back to merge proposal