Ubuntu Rest Scopes

Merge lp://staging/~knitzsche/ubuntu-rest-scopes/yahoofianance_news.finance_keyword into lp://staging/ubuntu-rest-scopes

  1. yahoofianance_news.finance_keyword
  2. Merge into trunk
Proposed by Kyle Nitzsche
Status: Merged
Approved by: Bret Barker
Approved revision: 478
Merged at revision: 478
Proposed branch: lp://staging/~knitzsche/ubuntu-rest-scopes/yahoofianance_news.finance_keyword
Merge into: lp://staging/ubuntu-rest-scopes
Diff against target: 12 lines (+1/-1)
1 file modified
configs/scopes-info.yaml (+1/-1)
To merge this branch: bzr merge lp://staging/~knitzsche/ubuntu-rest-scopes/yahoofianance_news.finance_keyword
Reviewer Review Type Date Requested Status
Facundo Batista (community) Approve
David Callé (community) Approve
Review via email: mp+262593@code.staging.launchpad.net

Commit message

Add news.finance keyword to yahoofinance so News scope can still aggregate it after the next update

Description of the change

Hi,

The news scope will now aggregate by "news.finance" keyword (not just "finance" because it is too generic).

This branch adds "news.finance" to yahoofinance scope.

Thanks,
Kyle

To post a comment you must log in.
Revision history for this message
David Callé (davidc3) wrote :

+1, thanks Kyle

review: Approve
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Does this need a "top approve" too?

Revision history for this message
Facundo Batista (facundo) wrote :

Nice

review: Approve
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

I guess I cannot do the merge. Can someone please? This is needed for Yahoo Finance to show up in the News aggregator scope we are about to release.

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

I was asked for a commit message. here it is:

Add news.finance keyword to yahoofinance so News scope can still aggregate it after the next update

Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

There was a problem validating some authors of the branch. Authors must be either one of the listed Launchpad users, or a member of one of the listed teams on Launchpad.

Persons or Teams:

    ubuntu-rest-scopes-hackers

Unaccepted Authors:

    Kyle Nitzsche <email address hidden>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches