Code review comment for lp://staging/~kfogel/bzr-hookless-email/byte-limit

Revision history for this message
Karl Fogel (kfogel) wrote :

Wouter van Heyst <email address hidden> writes:
>> > Why the default byte limit of ~40k? I mean, it might be a very good choice,
>> > but seems a bit arbitray. My initial guess would be 80 * default line
>> limit.
>>
>> Oh, I just gathered some sample data and looked at how many bytes 1000 lines
>> usually was. It turns out that 40 bytes per line average is normal for source
>> code (I guess it would be more when the source code is in some Unicode
>> encoding that uses more than one byte per char).
>
> Research is much better than my guess, your changes have been pushed
> to trunk :) Thanks for pinging me!

Thank you!

« Back to merge proposal