Code review comment for lp://staging/~kevang/mnemosyne-proj/number_keys_show_answer

Not sure this is a good idea. I think it's much better to prevent the fact that pressing and holding a number key counts as two presses at the moment. For the enter key, pressing and holding counts as one, so I need to investigate why it does not work for the number keys.

Cheers,

Peter

> -----Original Message-----
> From: <email address hidden> [mailto:<email address hidden>] On Behalf
> Of Kilian Evang
> Sent: 10 September 2014 23:41
> To: <email address hidden>
> Subject: [Merge] lp:~kevang/mnemosyne-
> proj/number_keys_show_answer into lp:mnemosyne-proj
>
> Kilian Evang has proposed merging lp:~kevang/mnemosyne-
> proj/number_keys_show_answer into lp:mnemosyne-proj.
>
> Requested reviews:
> Peter Bienstman (peter-bienstman)
>
> For more details, see:
> https://code.launchpad.net/~kevang/mnemosyne-
> proj/number_keys_show_answer/+merge/234210
>
> In the default review widget, the number keys can be used for showing the
> answer. While this behavior can be useful, it can also cause unintended
> showing and even unintended grading when the user accidentally presses a
> number key two or three times in a row.
>
> This branch makes the abovementioned behavior dependent on the
> attribute "number_keys_show_answer" so that the behavior can easily be
> changed by a plugin. This is analoguous to the already existing attribute
> "auto_focus_grades", which controls the behavior of grading by pressing the
> space bar.
> --
> https://code.launchpad.net/~kevang/mnemosyne-
> proj/number_keys_show_answer/+merge/234210
> You are requested to review the proposed merge of
> lp:~kevang/mnemosyne-proj/number_keys_show_answer into
> lp:mnemosyne-proj.