Code review comment for lp://staging/~kejun-zhou/lava-android-test/pm-qa

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

The $SHELL should have no value.
lava-android-test will not login to the shell to run the command.
lava-android-test just use "adb shell command" to run the script.
Below is the details about $SHELL.

17:24:25 liuyq:lava-master-image-scripts$ adb shell cat /data/local/test.sh
#!/system/bin/sh

echo $SHELL
17:24:42 liuyq:lava-master-image-scripts$ adb shell /data/local/test.sh

17:24:47 liuyq:lava-master-image-scripts$ adb shell
root@linaro: /data/local/test.sh
/system/bin/sh
root@linaro: ^D
17:24:58 liuyq:lava-master-image-scripts$

93 + for tests_dirs in $tests_dirs
Also please make the two variable name different

And also please update this file:
lava-android-test/MANIFEST.in

review: Needs Fixing

« Back to merge proposal