Code review comment for lp://staging/~kejun-zhou/lava-android-test/pm-qa

 24 busybox ln -s -f /system/bin/busybox wc
 25
 26 export PATH=/data/bin:$PATH
 27
* 28 cd /system/xbin/pm-qa*
 29
 30 pwd=$PWD
 31 echo $pwd
 32 tests_dirs="cpuidle cpufreq cpuhotplug sched_mc suspend thermal
utils"
 33 files=`find cpuidle cpufreq cpuhotplug sched_mc suspend thermal
utils -name "*.sh"`
 34

The line 28 is used to change the working DIR.

On 13 June 2012 17:26, Yongqin Liu <email address hidden> wrote:

> Review: Needs Fixing
>
> 92 + for tests_dirs in $tests_dirs
> the same variable name "tests_dirs" is used.
>
> 94 + subDir=`pwd`/$tests_dirs
> 95 + if [ -d $subDir ]; then
> 96 + cd $subDir
> 97 + fi
> the pm-qa.sh will be run like this "adb shell /xxx/pm-qa.sh"
> and the pwd should be the home of root "/",
> if you do not do something before run pm-qa.sh,
> I don't think there will be "cpuidle cpufreq cpuhotplug sched_mc suspend
> thermal utils" directories under the root directory.
> --
>
> https://code.launchpad.net/~kejun-zhou/lava-android-test/pm-qa/+merge/108892
> You are the owner of lp:~kejun-zhou/lava-android-test/pm-qa.
>