Mir

Code review comment for lp://staging/~kdub/mir/gbm-ext-v2

Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

Looks good. Some minor typos.

return comment is wrong.

41 +/** Access the import fd a MirBuffer
42 + * \pre The buffer is suitable for GBM_BO_IMPORT_FD
43 + * \warning The fd is owned by the buffer. Do not close() it.
44 + * \param [in] buffer The buffer
45 + * \return The stride of the buffer
46 + */
47 +typedef int (*MirBufferExtFd)(MirBuffer* buffer);
---------------------------------------------------------------
s/Check/Get

49 +/** Check the stride of a MirBuffer
50 + * \pre The buffer is suitable for GBM_BO_IMPORT_FD
51 + * \param [in] buffer The buffer
52 + * \return The stride of the buffer
53 + */
54 +typedef uint32_t (*MirBufferExtStride)(MirBuffer* buffer);

56 +/** Check the GBM_FORMAT of a MirBuffer
57 + * \pre The buffer is suitable for GBM_BO_IMPORT_FD
58 + * \param [in] buffer The buffer
59 + * \return The GBM_FORMAT of the buffer
60 + */
61 +typedef uint32_t (*MirBufferExtFormat)(MirBuffer* buffer);
-----------------------------------------------------------------------------
s/Check the gbm_bo_flags/Get buffer's age

70 +/** Check the gbm_bo_flags of a MirBuffer
71 + * \pre The buffer is suitable for GBM_BO_IMPORT_FD
72 + * \param [in] buffer The buffer
73 + * \return The age of the buffer
74 + */
75 +typedef uint64_t (*MirBufferExtAge)(MirBuffer* buffer);
76

review: Needs Fixing

« Back to merge proposal