Code review comment for lp://staging/~karni/ubuntuone-files-java-library/delta-support

Revision history for this message
Chad Miller (cmiller) wrote :

54 + callback.onFinish();

This is in the finally block, so you'll call it twice on out-of-error. Maybe also check that it's called only once here, as in all other tests.

595 + atLeast(1).of(nodeCallback).onFinish();
596 + inSequence(requestSequence);

242 + if ("from_generation".equals(jp.getCurrentName())) {
243 + // Ignore.
244 + } else

Do you need this?

review: Needs Fixing

« Back to merge proposal