Merge lp://staging/~karni/ubuntuone-android-files/omg-always-instant into lp://staging/ubuntuone-android-files
Proposed by
Michał Karnicki
| Status: | Merged |
|---|---|
| Approved by: | Chad Miller |
| Approved revision: | 209 |
| Merged at revision: | 209 |
| Proposed branch: | lp://staging/~karni/ubuntuone-android-files/omg-always-instant |
| Merge into: | lp://staging/ubuntuone-android-files |
| Diff against target: |
30 lines (+3/-11) 1 file modified
src/com/ubuntuone/android/files/service/MediaCatcher.java (+3/-11) |
| To merge this branch: | bzr merge lp://staging/~karni/ubuntuone-android-files/omg-always-instant |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Chad Miller (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Use onDestroy instead of stopService to shutdown the observer and cease triggering media uploads. stopService() is not called when the service is requested to be stopped and destroyed by Android, onDestroy is, however. So let's use that place and KILL that observer! Omg.. finally triaged that bug :)
FIXED Uploading instantly, although periodic sync is set.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Nice.