Merge lp://staging/~kamstrup/unity-lens-applications/recent-apps into lp://staging/unity-lens-applications

Proposed by Mikkel Kamstrup Erlandsen
Status: Merged
Approved by: Michal Hruby
Approved revision: 258
Merged at revision: 255
Proposed branch: lp://staging/~kamstrup/unity-lens-applications/recent-apps
Merge into: lp://staging/unity-lens-applications
Diff against target: 191 lines (+44/-24)
3 files modified
data/com.canonical.Unity.AppsLens.gschema.xml.in.in (+3/-3)
src/daemon.vala (+40/-20)
src/schemas.vala (+1/-1)
To merge this branch: bzr merge lp://staging/~kamstrup/unity-lens-applications/recent-apps
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
Review via email: mp+87757@code.staging.launchpad.net

Description of the change

Replaces the Frequently Used category with a Recently Used category.

When there is no search string it takes advantage of the new Unity.LauncherFavorites API to remove all apps that are faved in the launcher from the Recently Used category. When there is a search string all matching apps are included.

Also install a Zeitgeist monitor so we can mark our search results dirty when Zeitgeist tells us that the recent apps has changed. This means that (newer) Unities will see automatically refreshed results. (only newer because the Unities in Oneiric doesn't call the right method on the lens)

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

We need to determine if running (non-pinned) apps need to be excluded or not.

review: Needs Information
Revision history for this message
Michal Hruby (mhr3) wrote :

105 + private void on_zeitgeist_changed ()

This is going to need to invalidate GLOBAL search as well, isn't it?

Other than that it looks good. (and the exclusion of running apps will be done once bamf supports simpler method for that)

review: Needs Fixing
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Pushed the fix for invaliding global search. Please re-review.

Revision history for this message
Michal Hruby (mhr3) :
review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches