LightDM GTK Greeter

Merge lp://staging/~kalgasnik/lightdm-gtk-greeter/background-transition into lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk

  1. background-transition
  2. Merge into trunk
Proposed by Andrew P.
Status: Merged
Merged at revision: 316
Proposed branch: lp://staging/~kalgasnik/lightdm-gtk-greeter/background-transition
Merge into: lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk
Diff against target: 1452 lines (+646/-224)
5 files modified
src/Makefile.am (+3/-2)
src/greeterbackground.c (+543/-167)
src/greeterbackground.h (+5/-5)
src/lightdm-gtk-greeter.c (+95/-44)
src/lightdm-gtk-greeter.glade (+0/-6)
To merge this branch: bzr merge lp://staging/~kalgasnik/lightdm-gtk-greeter/background-transition
Reviewer Review Type Date Requested Status
Simon Steinbeiß Approve
Review via email: mp+241082@code.staging.launchpad.net

Description of the change

Add transition to backgrounds change.

1. Transition function: easy-in-out
2. Animation: drawing new background with different alpha over old background
3. Duration: 500ms
4. Delay before changing to user's background: 250ms

At first I thought to make all these things configurable, but someone can say that it is too much.
"transition-duration" is enough.

Enabled by default, I'm not sure that it is good idea.

To post a comment you must log in.
Revision history for this message
Andrew P. (kalgasnik) wrote :

There is one bug related to this branch: https://bugs.launchpad.net/ubuntu/+source/lightdm-gtk-greeter/+bug/1394639/comments/8

I can't confirm it so I can't fix it. I'm not even sure that trunk version is not effected.

Revision history for this message
Sean Davis (bluesabre) wrote :

Can you provide some examples for the configuration in this case?

Revision history for this message
Andrew P. (kalgasnik) wrote :

[greeter]
# 500 by default, 0 to disable transition effect
transition-duration = <duration-in-ms>

# Transition function, "none" to disable transition effect
# "easy-in-out" by default
transition-type = easy-in-out|linear|none

Revision history for this message
Sean Davis (bluesabre) wrote :

When I try this on my laptop, there does not seem to be a transition...

transition-duration=1000
transition-type=easy-in-out

Revision history for this message
Andrew P. (kalgasnik) wrote :

Maybe you have user-background = false or identical default and user's backgrounds.
It must looks like http://youtu.be/hVtoEtG-OXE

Oh, "easy" -> "ease", my inglish is not so well. But it isn't the source of the problem.

Revision history for this message
Simon Steinbeiß (ochosi) wrote :

I've checked out your branch (mostly testing, not code review) and it works just fine! Nice work on that and sorry it took so long.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches