Code review comment for lp://staging/~julian-edwards/maas/enable_dhcp_when_setting_up_params

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Makes sense. One small thing: in that last test, it may help to disable manage_dhcp explicitly. If we ever decide to change the default, or there's another test isolation problem, it'll be good to know that the test isn't passing for the wrong reason.

Jeroen

review: Approve

« Back to merge proposal