Code review comment for lp://staging/~julian-edwards/launchpad/sp-changelog-30

Revision history for this message
Julian Edwards (julian-edwards) wrote :

= Summary =
Convert source package change logs page to 3.0

== Implementation details ==
Fairly mundane conversion. I had to split up the view into a separate class
for this page so that I could implement a "label" property specific to this
page. This isn't strictly necessary right now but when Barry's headings
branch lands it will be used, and I can remove the explicit <h1> in the
template. That will be done en-masse along with all the other pages that
currently do this.

While I was in the zcml, I changed the location of two templates
(productseries-packaging.pt and sourcepackage-packaging.pt) which should
belong to Registry, not Soyuz, as they deal with upstream packaging linkage.

== Tests ==
bin/test -vvct xx-sourcepackage-changelog.txt

== Demo and Q/A ==
See https://launchpad.dev/ubuntu/hoary/+source/alsa-utils/+changelog

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/soyuz/stories/soyuz/xx-sourcepackage-changelog.txt
  lib/lp/registry/browser/configure.zcml
  lib/lp/soyuz/browser/sourcepackage.py
  lib/lp/soyuz/browser/configure.zcml
  lib/lp/soyuz/templates/sourcepackage-changelog.pt

« Back to merge proposal