Code review comment for lp://staging/~julian-edwards/launchpad/schema-distro-parents

Revision history for this message
Stuart Bishop (stub) wrote :

Discussed on IRC.

The proposed DB patch is fine from DBA pov.

Consider if an enum would be more use than a boolean field.

No need to add checks that the child != parent - the Python code already needs to maintain more than this to avoid loops.

patch-2208-61-0.sql

review: Approve (db)

« Back to merge proposal