Code review comment for lp://staging/~julian-edwards/launchpad/mechanical-changes-8

Revision history for this message
Julian Edwards (julian-edwards) wrote :

= Summary =
3.0 mechanical changes to sourcepackage builds lists

== Implementation details ==
* SourcePackageView no longer inherits from BuildRecords view
* New view SourcePackageBuildsView for the converted page so that it better
encapsulates the build-related stuff, and has a separate page title.
* Very trivial template change!

As a bonus, I fixed the headings on the distroseriesbinarypackage-index.pt
that I committed a couple of hours ago, the h1 and h2 were the wrong way
around (and nobody spotted it!).

== Tests ==
bin/test -cvvt xx-builds-pages

== Demo and Q/A ==
For the builds change:
https://launchpad.dev/ubuntu/warty/+source/mozilla-firefox/+builds

For the h1/h2 swap:
https://launchpad.dev/ubuntu/warty/+package/mozilla-firefox/
or
https://dogfood.launchpad.net/ubuntu/hardy/+package/kmail

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/browser/sourcepackage.py
  lib/lp/soyuz/templates/sourcepackage-builds.pt
  lib/lp/soyuz/browser/sourcepackagebuilds.py
  lib/lp/soyuz/templates/distroseriesbinarypackage-index.pt
  lib/lp/soyuz/browser/configure.zcml

« Back to merge proposal