Code review comment for lp://staging/~julian-edwards/launchpad/mechanical-changes-7

Revision history for this message
Michael Nelson (michael.nelson) wrote :

<noodles> bigjools: sorry, not part of a ui review I know, but do we have any rules about using non-ascii characters in tests? I've always seen people doing ... instead of “
<noodles> I think it's much more readable just to use it as you have...
<bigjools> noodles: I honestly don't know
<bigjools> exactly, and it passes ...
<noodles> yep.
<noodles> ouch... I just saw what this page used tot look like! Gee it's nice seeing all these changes!
<bigjools> :)
<bigjools> horrible wasn't it
<noodles> Yeah, having the publishings down the side...
* bigjools has quit (Ping timeout)
* bigjools (<email address hidden>) has joined #launchpad-soyuz
<bigjools> intel drivers FTW again
<noodles> bigjools: looks great. My only thought (there's always one isn't there... is that I think we should update the h2: "Published as" to something that doesn't require context.
<noodles> heh
<bigjools> not sure I completely understand
<noodles> hmm... maybe not. I was thinking that instead of "Published as", maybe "Publications of 'kmail' in Ubuntu Hardy"
<noodles> but that's too much context.
<noodles> Any ideas? Or do you think there's no benefit in changing from "Publish as"...?
<bigjools> "Published versions" maybe
<noodles> Yeah, perfect

review: Approve (ui)

« Back to merge proposal