Code review comment for lp://staging/~julian-edwards/launchpad/mechanical-changes-7

Revision history for this message
Julian Edwards (julian-edwards) wrote :

= Summary =
Mechanical 3.0 conversion of distroseriesbinarypackage page

== Implementation details ==
Pretty straightforward template conversion of
lib/lp/soyuz/templates/distroseriesbinarypackage-index.pt

The two side portlets are removed, although the publishing details one has
moved to the bottom of the main content.

I also took the opportunity to clean up the page test a bit.

== Tests ==
bin/test -vvt xx-distroseries-binary-packages.txt

== Demo and Q/A ==
See dogfood:
https://dogfood.launchpad.net/ubuntu/hardy/+package/kmail

Or in .dev:
https://launchpad.dev/ubuntu/warty/+package/mozilla-firefox/

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/pagetitles.py
  lib/lp/soyuz/templates/distroseriesbinarypackage-index.pt
  lib/lp/soyuz/browser/distroseriesbinarypackage.py
  lib/lp/soyuz/stories/soyuz/xx-distroseries-binary-packages.txt

« Back to merge proposal