Code review comment for lp://staging/~julian-edwards/launchpad/mechanical-changes-6

Revision history for this message
Julian Edwards (julian-edwards) wrote :

= Summary =
Mechanical 3.0 changes for DistroArchSeriesBinaryPackage[Release] pages

== Implementation details ==
I slipped in a quick bug fix while I was at it:
https://bugs.edge.launchpad.net/bugs/241341
to fix a page heading. This was just a case of changing the title property on
the context class.

The change to the DistroArchSeriesBinaryPackage is trivial and can be seen
here:
https://launchpad.dev/ubuntu/warty/i386/mozilla-firefox

The change to the DistroArchSeriesBinaryPackageRelease page was more involved.
It uses several page fragments in the package relationships section that are
in a different context/view. They are not used anywhere else so I added some
conditional "yui-u" div classes to those so that they don't appear when not
necessary.

The breadcrumbs on both pages are not working properly, I will fix those in a
separate branch.

== Tests ==
bin/test -vvt stories.soyuz -t distroarchseriesbinarypackage

== Demo and Q/A ==
See the URLs above.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/soyuz/doc/distroarchseriesbinarypackage.txt
  lib/lp/soyuz/templates/binarypackagerelease-portlet-predepends.pt
  lib/lp/soyuz/templates/binarypackagerelease-portlet-depends.pt
  lib/lp/soyuz/templates/binarypackagerelease-portlet-suggests.pt
  lib/lp/soyuz/templates/distroarchseriesbinarypackagerelease-portlet-
details.pt
  lib/lp/soyuz/templates/binarypackagerelease-portlet-conflicts.pt
  lib/lp/soyuz/templates/distroarchseriesbinarypackage-index.pt
  lib/lp/soyuz/templates/binarypackagerelease-portlet-enhances.pt
  lib/lp/soyuz/templates/binarypackagerelease-portlet-replaces.pt
  lib/lp/soyuz/templates/distroarchseriesbinarypackagerelease-index.pt
  lib/lp/soyuz/templates/binarypackagerelease-portlet-recommends.pt
  lib/lp/soyuz/model/distroarchseriesbinarypackage.py
  lib/lp/soyuz/templates/binarypackagerelease-portlet-provides.pt
  lib/lp/soyuz/templates/binarypackagerelease-portlet-breaks.pt

« Back to merge proposal