Code review comment for lp://staging/~julian-edwards/launchpad/mechanical-30-ui-changes-4

Revision history for this message
Deryck Hodge (deryck) wrote :

Hi, Julian.

This looks good to me.

As mentioned on IRC, I think (based on Curtis' last email to our dev list) that we don't need the h1 headings defined inside the headling slot. I'll still mark Approve since as you see this isn't clear to you and you've done other pages this same way. But I do want to note it and ask Curtis or Martin A. to confirm.

Cheers,
deryck

review: Approve

« Back to merge proposal