Code review comment for lp://staging/~julian-edwards/launchpad/mechanical-30-ui-changes-4

Revision history for this message
Julian Edwards (julian-edwards) wrote :

= Summary =
More mechanical 3.0 updates

== Proposed fix ==
Two more pages updated:
 * DistroArchSeries:+admin
 * DistributionSourcePackage:+publishinghistory

== Implementation details ==
The DistroArchSeries:+admin used a Zope form which I had to convert to an
LPForm so that I could add next_url, cancel_url and page_title in the new view
class.

== Tests ==
bin/test -vvt xx-distroarchseries.txt

== Demo and Q/A ==
The pages are at:
 * https://launchpad.dev/ubuntu/+source/alsa-utils/+publishinghistory
 * https://launchpad.dev/ubuntu/breezy-autotest/i386/+admin

You need to be logged in as an admin for the latter.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/pagetitles.py
  lib/lp/soyuz/templates/distroarchseries-admin.pt
  lib/lp/soyuz/stories/soyuz/xx-distroarchseries.txt
  lib/lp/soyuz/browser/configure.zcml
  lib/lp/soyuz/browser/distroarchseries.py
  lib/lp/soyuz/templates/distributionsourcepackage-publishinghistory.pt

== Pylint notices ==

lib/lp/soyuz/browser/distroarchseries.py
    19: [C0301] Line too long (79/78)

Gah, warning me about this is too fscking late here. I'll have it fixed by
the time you read this MP.

« Back to merge proposal