Merge lp://staging/~julian-edwards/launchpad/dsp-involvement-bug-420480 into lp://staging/launchpad

= Summary =
Fix involvement menu for DistributionSourcePackage

== Proposed fix ==
The code at lib/lp/registry/browser/pillar.py calculates what kind of
involvement a pillar has. Because it assumes that the pillar is a
distribution for a distributionsourcepackage page, it can activate the
blueprints link which is not applicable to them.

== Pre-implementation notes ==
Spoke to Curtis, he said to just add an exception similar to the existing
"projectgroups" one.

== Tests ==
bin/test -vvt pillar-views.txt

== Demo and Q/A ==
Nothing to show yet until my new page design lands. I am just breaking this
code out to a separate branch for ease of review.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/browser/pillar.py
  lib/lp/registry/browser/tests/pillar-views.txt

Hi Julian,

a nice branch. As mentioned on IRC, I think you don't

> === modified file 'lib/lp/registry/browser/pillar.py'
> --- lib/lp/registry/browser/pillar.py 2009-08-18 14:36:16 +0000
> +++ lib/lp/registry/browser/pillar.py 2009-08-28 12:01:27 +0000
> @@ -20,6 +20,8 @@
> from canonical.launchpad.webapp.publisher import LaunchpadView, nearest
> from canonical.launchpad.webapp.tales import MenuAPI
>
> +from lp.registry.interfaces.distributionsourcepackage import (
> + IDistributionSourcePackage)
> from lp.registry.interfaces.pillar import IPillar
> from lp.registry.interfaces.project import IProject
>
> @@ -78,6 +80,10 @@
> self._set_official_launchpad(product)
> # Projectgroups do not support submit code.
> self.official_codehosting = False
> + elif IDistributionSourcePackage.providedBy(self.context):
> + # Distro source packages don't have blueprints.
> + self._set_official_launchpad(pillar)
> + self.official_blueprints = False

self.official_blueprints is already set to False a few lines above, in the "unconcitional part" of __init__()

Abel

> else:
> self._set_official_launchpad(pillar)
>

On Friday 28 August 2009 14:09:02 Abel Deuring wrote:
> >
> > @@ -78,6 +80,10 @@
> > self._set_official_launchpad(product)
> > # Projectgroups do not support submit code.
> > self.official_codehosting = False
> > + elif IDistributionSourcePackage.providedBy(self.context):
> > + # Distro source packages don't have blueprints.
> > + self._set_official_launchpad(pillar)
> > + self.official_blueprints = False
>
> self.official_blueprints is already set to False a few lines above, in the
> "unconcitional part" of __init__()
>
> Abel

Hi, as mentioned on IRC, it's overriding what
self._set_official_launchpad(pillar) sets it to (which is True, because the
pillar is the distro).

I'll make those comments clearer to explain that.

Thanks for the review.