Code review comment for lp://staging/~julian-edwards/launchpad/count-cull
Revision history for this message
| Julian Edwards (julian-edwards) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
2eb648a
demo site
(Get the code!)
On Thursday 13 January 2011 20:39:08 you wrote:
> Review: Approve
> To confirm I grok this: rather than forcing a complete evaluation, we do a
> LIMIT 1 query? Sounds reasonable to me.
Yup, that's what is_empty() does, which is what __nonzero__ calls. I've also
avoided double queries in places by just trying to access the data and
catching IndexError.