Code review comment for lp://staging/~julian-edwards/launchpad/breadcrumbs-bug-423242

Revision history for this message
Julian Edwards (julian-edwards) wrote :

= Summary =
Add breadcrumbs to DistroArchSeries and onwards traversals

== Pre-implementation notes ==
Salgado advised on how to do this, it's trivial to add and test.

== Implementation details ==
I added breadcrumbs for DistroArchSeries[BinaryPackage][Release] pages in 2
stages:
 * Add an adapter to the browser class
 * Register it in the zcml

== Tests ==
New tests added, run:
bin/test -vvt TestDistroArchSeriesBreadcrumb

== Demo and Q/A ==
See
https://launchpad.dev/ubuntu/hoary/i386
https://launchpad.dev/ubuntu/hoary/i386/pmount
https://launchpad.dev/ubuntu/hoary/i386/pmount/0.1-1

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/soyuz/browser/tests/test_breadcrumbs.py
  lib/lp/soyuz/configure.zcml
  lib/lp/soyuz/browser/distroarchseriesbinarypackagerelease.py
  lib/lp/soyuz/browser/distroarchseriesbinarypackage.py
  lib/lp/soyuz/browser/distroarchseries.py

« Back to merge proposal