Code review comment for lp://staging/~jtv/launchpad/recife-add-suggestion

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

See revision 9132 above:
 * Renamed lp.registry.tests.karma to lp.testing.karma to deal with import problems.
 * Renamed KarmaListener to KarmaRecorder, moved into lp.testing.karma.
 * Made KarmaRecorder a bit more flexible, turned existing KarmaAssignedEventListener into a subclass.
 * Moved set_branding from canonical.launchpad.ftests to a new module lp.testing.branding to deal with import problems.
 * Moved makePOFileAndPOTMsgSet into the factory.
 * Removed test helper _suggest, calling submitSuggestion directly instead.
 * Used the factory to create TranslationMessages in the test, instead of updateTranslation.
 * Unrolled the poorly legible test loop. Don't really need to test _all_ possible plural forms.

Jeroen

« Back to merge proposal